[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02bf5632a94d: Fix swig scripts install target name (authored by aadsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

aadsm updated this revision to Diff 287106. aadsm edited the summary of this revision. aadsm added a comment. Updated to use more friendly component name `lldb-python-scripts` name instead of `finish_swig_python_scripts` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

JDevlieghere added a comment. In D86235#2227052 , @aadsm wrote: > @JDevlieghere thanks for the quick review, but on the name I mean the actual > `finish_swig_python_scripts`, this sounds like a step name and not a > component distributed by llvm like `li

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

aadsm added a comment. @JDevlieghere thanks for the quick review, but on the name I mean the actual `finish_swig_python_scripts`, this sounds like a step name and not a component distributed by llvm like `liblldb` ot `lldb-server`. That was the reason at the time I named it `lldb-python-scripts

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. No reason other than consistency by always appending to the given target. I didn't think of the requirement for the `install-`prefix. LGTM! Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

aadsm created this revision. aadsm added reviewers: JDevlieghere, wallace, clayborg. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. aadsm requested review of this revision. LLVM install component targets needs to be in the form of: install-{target}[-stripped] I tes