aadsm created this revision.
aadsm added reviewers: JDevlieghere, wallace, clayborg.
Herald added subscribers: lldb-commits, mgorny.
Herald added a project: LLDB.
aadsm requested review of this revision.
LLVM install component targets needs to be in the form of:
install-{target}[-stripped]
I tested with:
cmake ... -DLLVM_ENABLE_PROJECTS="clang;lldb"
-DLLVM_DISTRIBUTION_COMPONENTS="lldb;liblldb;finish_swig_python_scripts" ...
DESTDIR=... ninja install-distribution
@JDevlieghere `finish_swig_python_scripts` is a really weird name for a
distribution component, any reason that it has to be this way?
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D86235
Files:
lldb/bindings/python/CMakeLists.txt
Index: lldb/bindings/python/CMakeLists.txt
===================================================================
--- lldb/bindings/python/CMakeLists.txt
+++ lldb/bindings/python/CMakeLists.txt
@@ -164,7 +164,7 @@
string(REPLACE ${CMAKE_CFG_INTDIR} "\$\{CMAKE_INSTALL_CONFIG_NAME\}"
lldb_python_target_dir ${lldb_python_target_dir})
endif()
set(swig_scripts_target "${swig_target}_scripts")
- set(swig_scripts_install_target "${swig_target}_scripts_install")
+ set(swig_scripts_install_target "install-${swig_scripts_target}")
add_custom_target(${swig_scripts_target})
add_dependencies(${swig_scripts_target} ${swig_target})
install(DIRECTORY ${lldb_python_target_dir}/../
Index: lldb/bindings/python/CMakeLists.txt
===================================================================
--- lldb/bindings/python/CMakeLists.txt
+++ lldb/bindings/python/CMakeLists.txt
@@ -164,7 +164,7 @@
string(REPLACE ${CMAKE_CFG_INTDIR} "\$\{CMAKE_INSTALL_CONFIG_NAME\}" lldb_python_target_dir ${lldb_python_target_dir})
endif()
set(swig_scripts_target "${swig_target}_scripts")
- set(swig_scripts_install_target "${swig_target}_scripts_install")
+ set(swig_scripts_install_target "install-${swig_scripts_target}")
add_custom_target(${swig_scripts_target})
add_dependencies(${swig_scripts_target} ${swig_target})
install(DIRECTORY ${lldb_python_target_dir}/../
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
