[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

labath added a comment. I'm pretty sure that's because YAMA prevents the attach operation. The test probably needs to launch the binary through something like this . Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

aeubanks added a comment. Herald added a project: All. the added test `TestVSCode_runInTerminal` consistently fails for me locally with Failed to attach to the target process. Timed out trying to get messages from the runInTerminal launcher I've asked other people and they've also reported co

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

wallace updated this revision to Diff 289542. wallace added a comment. Now this feature is fully functional. Besiding adding a test, I was able to debug LLDB from an integrated terminal in VSCode. Stdin and stdout work correctly. I'm attaching asynchronously to the inferior using the wait-for l

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

wallace commandeered this revision. wallace edited reviewers, added: aelitashen; removed: wallace. wallace added a comment. We found a very strange issue with lldb not stopping at any breakpoint after attaching. I'll figure that out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

aelitashen updated this revision to Diff 286885. aelitashen added a comment. @Walter Please help me fix the tests. Looks like in the new added runInTerminal tests, it cannot hit the breakpoint and capture the local variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. All of the code looks good now and we need to add a test. This means we will need to modify vscode.py in the test suite to be able to received the reverse request and just launch

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

aelitashen added a comment. I tried rebase onto the commit that Walter created just for formatting but I am not sure why it didn't remove those formatting noise.. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:410 + +VSCode::PacketStatus VSCode::SendReverseRequest(llvm::json::O

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

aelitashen updated this revision to Diff 286620. aelitashen added a comment. Refactor code and optimize logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84974/new/ https://reviews.llvm.org/D84974 Files: lldb/tools/lldb-vscode/VSCode.cpp lld

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:410 + +VSCode::PacketStatus VSCode::SendReverseRequest(llvm::json::Object &request, +llvm::json::Object &response) { clayborg wrote: > cl

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:410 + +VSCode::PacketStatus VSCode::SendReverseRequest(llvm::json::Object &request, +llvm::json::Object &response) { clayborg wrote: > ad

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.h:173 + + void RegisterRequestCallback(std::string request, RequestCallback callback); }; I thought this was the contents of a "lldb::SBTarget CreateTargetFromArguments(const llvm::json:

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aelitashen requested review of this revision. Herald added a subscriber: JDevlieghere. When turn on "Launch In Terminal" in IDE, the debugee will