clayborg added inline comments.
================
Comment at: lldb/tools/lldb-vscode/VSCode.cpp:410
+
+VSCode::PacketStatus VSCode::SendReverseRequest(llvm::json::Object &request,
+ llvm::json::Object &response) {
----------------
clayborg wrote:
> add "const" to before "llvm::json::Object &request"
I see we are modifying "request" below, so we can't make it "const". There are
two ways to fix this:
1 - change it to be "llvm::json::Object request" and then use std::move() when
calling SendReverseRequest.
2 - just leave as a reference and modify the original object.
I think I prefer option #1.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84974/new/
https://reviews.llvm.org/D84974
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
