MaskRay added inline comments.
Comment at: lldb/source/Core/Section.cpp:570
+ while (file_addr < end) {
+SectionSP sect_sp = FindSectionContainingFileAddress(file_addr);
+if (!sect_sp)
I am a bit concerned about the potential large time complexity
here.
labath planned changes to this revision.
labath added a comment.
Waiting for the resolution of the discussion in the follow-up patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84401/new/
https://reviews.llvm.org/D84401
__
clayborg added inline comments.
Comment at: lldb/include/lldb/Core/Section.h:75
+ /// sections in this list.
+ bool ContainsFileAddressRange(lldb::addr_t addr, lldb::addr_t size) const;
+
JDevlieghere wrote:
> `addr_t` looks a bit weird for the size, but then `
JDevlieghere accepted this revision.
JDevlieghere added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/include/lldb/Core/Section.h:75
+ /// sections in this list.
+ bool ContainsFileAddressRange(lldb::addr_t addr, lldb::addr_t size) const;
+
labath created this revision.
labath added reviewers: JDevlieghere, clayborg.
Herald added a subscriber: mgorny.
Herald added a project: LLDB.
This is similar to FindSectionContainingFileAddress, except it doesn't
return a section (because that would be ambiguous), and it checks for an
address ran
