MaskRay added inline comments.
================
Comment at: lldb/source/Core/Section.cpp:570
+ while (file_addr < end) {
+ SectionSP sect_sp = FindSectionContainingFileAddress(file_addr);
+ if (!sect_sp)
----------------
I am a bit concerned about the potential large time complexity
here.FindSectionContainingFileAddress is O(|sections|) and this loop usually
executes once but can take a lot of iterations in a pessimistic case. See my
comment in D84402.
================
Comment at: lldb/unittests/Core/SectionTest.cpp:43
+ Flags: [ SHF_ALLOC ]
+ Address: 0x0031
+ Size: 0x000f
----------------
Might be useful leaving a comment that there is a gap.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84401/new/
https://reviews.llvm.org/D84401
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
