[Lldb-commits] [PATCH] D78978: [LLDB] Add support for WebAssembly debugging

2021-01-11 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. Thanks for the explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78978/new/ https://reviews.llvm.org/D78978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D78978: [LLDB] Add support for WebAssembly debugging

2021-01-11 Thread Paolo Severini via Phabricator via lldb-commits
paolosev added a comment. In D78978#2488134 , @aprantl wrote: > What's the testing story for WASM going to be? Thanks for the feedback @aprantl! This patch was also create to show a possible alternative to https://reviews.llvm.org/D78801, but D78801

[Lldb-commits] [PATCH] D78978: [LLDB] Add support for WebAssembly debugging

2021-01-08 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. What's the testing story for WASM going to be? Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h:300 + // WebAssembly-specific commands + bool GetWasmGlobal(int frame_index, int index, void *buf, size_t buffer_size,

[Lldb-commits] [PATCH] D78978: [LLDB] Add support for WebAssembly debugging

2021-01-06 Thread Paolo Severini via Phabricator via lldb-commits
paolosev added a comment. In D78978#2483354 , @dblaikie wrote: > Usually the thing is to ping the review thread at most weekly & maybe search > around for specific reviewers to ask if you're met with a lot of silence. There was not a lot of feedback on t

[Lldb-commits] [PATCH] D78978: [LLDB] Add support for WebAssembly debugging

2021-01-06 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added a comment. In D78978#2483327 , @paolosev wrote: > In D78978#2481358 , @vwzm228 wrote: > >> Is there any progress about such patch and D78801 >> ? >> >> I have impleme

[Lldb-commits] [PATCH] D78978: [LLDB] Add support for WebAssembly debugging

2021-01-06 Thread Paolo Severini via Phabricator via lldb-commits
paolosev added a comment. In D78978#2481358 , @vwzm228 wrote: > Is there any progress about such patch and D78801 > ? > > I have implemented the debugging feature in our Wasm VM based on > https://reviews.llvm.org/D78801

[Lldb-commits] [PATCH] D78978: [LLDB] Add support for WebAssembly debugging

2021-01-05 Thread Zhongmin Wu via Phabricator via lldb-commits
vwzm228 added a comment. Herald added a subscriber: JDevlieghere. Is there any progress about such patch and D78801 ? I have implemented the debugging feature in our Wasm VM based on https://reviews.llvm.org/D78801, and it already work to attach, set breakpoint

[Lldb-commits] [PATCH] D78978: [LLDB] Add support for WebAssembly debugging

2020-04-27 Thread Paolo Severini via Phabricator via lldb-commits
paolosev created this revision. paolosev added reviewers: labath, clayborg. paolosev added a project: LLDB. Herald added subscribers: lldb-commits, sunfish, aheejin, jgravelle-google, sbc100, aprantl, mgorny, dschuff. paolosev edited the summary of this revision. This patch is a refactoring of h