paolosev added a comment. In D78978#2488134 <https://reviews.llvm.org/D78978#2488134>, @aprantl wrote:
> What's the testing story for WASM going to be? Thanks for the feedback @aprantl! This patch was also create to show a possible alternative to https://reviews.llvm.org/D78801, but D78801 <https://reviews.llvm.org/D78801> has evolved since then and I should probably close/abandon this one. I had not looked at the testing story for Wasm yet because it seemed that the changes to the core code could have been a showstopper, but we would need to test a process connected to LLDB through a GDBRemote connection. I see that this is normally done using the //lldbsuite// package, //GdbRemoteTestCaseBase//, which actually launches the debuggee process. We cannot do the same for Wasm, we cannot run a JS engine that implements a GDB Stub here. We should instead write code similar to GdbRemoteTestCaseBase that simulates a Wasm process, implementing a GDB stub, handling GDBRemote messages (both generic and Wasm-specific). (This is the opposite of the work done to test the implementation of the GDB Stub in V8: there we had the process and we had to simulate the debugger). Furthermore, we could also extend: - test\Shell\Reproducer\TestGDBRemoteRepro.test - test\API\functionalities\gdb_remote_client\TestGDBRemoteClient.py with other Wasm-specific tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78978/new/ https://reviews.llvm.org/D78978 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
