[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e04b5f2fa84: [nfc] [lldb] Introduce DWARF callbacks (fixed-up) (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https:

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

mib accepted this revision. mib added a comment. It looks like there's no more regression. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 ___ lld

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

mib added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:143 + if (m_apple_types_up->FindByName(context[1].name, + [&](DIERef ref) { return false; })) return; jankratochvil

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:143 + if (m_apple_types_up->FindByName(context[1].name, + [&](DIERef ref) { return

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

jankratochvil updated this revision to Diff 257830. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/s

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

jankratochvil reopened this revision. jankratochvil added a comment. This revision is now accepted and ready to land. I had to revert it: rG9289f34390da It has caused a regression: `lang/cpp/accelerator-table/TestCPPAccelerator

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd47c470d13b: [nfc] [lldb] Introduce DWARF callbacks (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.l

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Cool. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 __

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

jankratochvil added a comment. In D77327#1980079 , @labath wrote: > The normal semantics of callbacks like these is to return `true` when one > wants to continue iterating OK, fixed, thanks for catching it. > One cannot guarantee that the `debug_names`

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

jankratochvil updated this revision to Diff 257389. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cp

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

labath added a comment. In D77327#1971794 , @jankratochvil wrote: > In D77327#1971435 , @labath wrote: > > > The `bool` return value on all of these methods, is that here just to > > implement the `fallback` mecha