jankratochvil added a comment.

In D77327#1980079 <https://reviews.llvm.org/D77327#1980079>, @labath wrote:

> The normal semantics of callbacks like these is to return `true` when one 
> wants to continue iterating


OK, fixed, thanks for catching it.

> One cannot guarantee that the `debug_names` section will cover all 
> compilation units in a given file. So we still need to call the manual index 
> to index the rest. However we pass it a list of units it should avoid (see 
> `DebugNamesDWARFIndex` constructor), so we don't index everything twice.

OK, that `llvm::DenseSet<dw_offset_t> units_to_avoid`.  Thanks for the 
explanation, it makes sense now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77327/new/

https://reviews.llvm.org/D77327



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to