[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

compnerd added a comment. Thanks @thakis - 906e60b9f923464cba0f71a9205846550752162f should have addressed that from a few days ago (sorry about not mentioning that here) Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

thakis added inline comments. Comment at: lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp:397 + +error.SetErrorStringWithFormat("LoadLibrary Error: %lu", error_code); +return LLDB_INVALID_IMAGE_TOKEN; ``` ../../lldb/source/Plugins/Platform/Window

[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

This revision was automatically updated to reflect the committed changes. compnerd marked an inline comment as done. Closed by commit rGf1585a4b47cc: Windows: support `DoLoadImage` (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D77287?vs=390249&id=391847#toc Reposito

[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: lldb/source/Plugins/Platform/Windows/PlatformWindows.h:47-51 + uint32_t DoLoadImage(lldb_private::Process *process, + const lldb_private::FileSpec &remote_file, +

[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

JDevlieghere added a comment. I can't speak to the correctness of the Windows parts, but all the utility function stuff looks sane to me. LGTM if Pavel has no outstanding objections. Comment at: lldb/source/Plugins/Platform/Windows/PlatformWindows.h:47-51 + uint32_t DoLoadIma

[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

compnerd updated this revision to Diff 390249. compnerd added a comment. Add missing null-terminators. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77287/new/ https://reviews.llvm.org/D77287 Files: lldb/source/Plugins/Platform/Windows/CMakeLists.txt lldb/source/Plugins/Platform/Wi

[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

compnerd updated this revision to Diff 390246. compnerd added a comment. Herald added a subscriber: mgorny. Fix build rules Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77287/new/ https://reviews.llvm.org/D77287 Files: lldb/source/Plugins/Platf

[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

compnerd updated this revision to Diff 390245. compnerd retitled this revision from "Windows: add very basic support for `DoLoadImage`" to "Windows: support `DoLoadImage`". compnerd edited the summary of this revision. compnerd added a comment. This is a more complete implementation that allows f