[Lldb-commits] [PATCH] D68248: [JSON] Use LLVM's library for encoding JSON

This revision was automatically updated to reflect the committed changes. Closed by commit rL373359: [JSON] Use LLVM's library for encoding JSON in StructuredData (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[Lldb-commits] [PATCH] D68248: [JSON] Use LLVM's library for encoding JSON

JDevlieghere added a comment. In D68248#1688975 , @vsk wrote: > Sweet! Does this 'automatically' fix the 'llvm-argdumper has issues escaping > JSON-ified input' issue we discussed in person? No, that uses the JSON class that Pavel mentioned. My hope is

[Lldb-commits] [PATCH] D68248: [JSON] Use LLVM's library for encoding JSON

aprantl added a comment. Cool. I mean both are supposed to be JSON, but are we expecting any fallout from a debugserver using the old library vs and lldb using the new one? I suppose not.. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68248/new/ https://revie

[Lldb-commits] [PATCH] D68248: [JSON] Use LLVM's library for encoding JSON

labath accepted this revision. labath added a comment. Yay. BTW, there's another copy of json serialization code in JSON.cpp (JSONValue::Write). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68248/new/ https://reviews.llvm.org/D68248 __

[Lldb-commits] [PATCH] D68248: [JSON] Use LLVM's library for encoding JSON

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Sweet! Does this 'automatically' fix the 'llvm-argdumper has issues escaping JSON-ified input' issue we discussed in person? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D68248: [JSON] Use LLVM's library for encoding JSON

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp:387 std::string expected_packet1 = - R"(jTraceStart:{"buffersize" : 8192,"metabuffersize" : 8192,"params"

[Lldb-commits] [PATCH] D68248: [JSON] Use LLVM's library for encoding JSON

shafik added inline comments. Comment at: lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp:387 std::string expected_packet1 = - R"(jTraceStart:{"buffersize" : 8192,"metabuffersize" : 8192,"params" :)"; + R"(jTraceStart:{"buffersize":8192,"metab

[Lldb-commits] [PATCH] D68248: [JSON] Use LLVM's library for encoding JSON

JDevlieghere created this revision. JDevlieghere added reviewers: labath, mgorny, xiaobai, aprantl, clayborg. Herald added a subscriber: abidh. Herald added a project: LLDB. This patch replaces the hand-rolled JSON emission with LLVM's JSON library. Repository: rLLDB LLDB https://reviews.llvm