[Lldb-commits] [PATCH] D67993: [lldb] Calculate relative path for symbol links

This revision was automatically updated to reflect the committed changes. Closed by commit rL373668: [lldb] Calculate relative path for symbol links (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[Lldb-commits] [PATCH] D67993: [lldb] Calculate relative path for symbol links

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks fine. There is no xcode build. If you want to test building the framework, you just need to set LLDB_BUILD_FRAMEWORK cmake variable. I don't know if there's any other var than need

[Lldb-commits] [PATCH] D67993: [lldb] Calculate relative path for symbol links

hhb added a comment. In D67993#1681901 , @mgorny wrote: > Yep, that's a change in the right direction. Have you (at least mentally) > verified that it produces the correct path in all cases? I wouldn't trust the > inputs being entirely correct. So far

[Lldb-commits] [PATCH] D67993: [lldb] Calculate relative path for symbol links

mgorny added a comment. Yep, that's a change in the right direction. Have you (at least mentally) verified that it produces the correct path in all cases? I wouldn't trust the inputs being entirely correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D67993: [lldb] Calculate relative path for symbol links

hhb created this revision. hhb added reviewers: labath, mgorny. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This replaces the hard coded path. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67993 Files: lldb/scripts/Python/finishSwigPythonLLDB.py