labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

This looks fine.

There is no xcode build. If you want to test building the framework, you just 
need to set LLDB_BUILD_FRAMEWORK cmake variable. I don't know if there's any 
other var than needs setting, but we have a cache file 
(cmake/caches/Apple-lldb-Xcode.cmake), which should build things the same way 
as the apple folks are building, so you could just use that.



================
Comment at: lldb/scripts/Python/finishSwigPythonLLDB.py:383
     bMakeFileCalled = "-m" in vDictArgs
     eOSType = utilsOsType.determine_os_type()
 
----------------
I guess this is unused now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67993/new/

https://reviews.llvm.org/D67993



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to