[Lldb-commits] [PATCH] D67583: Fix swig python package path

mgorny added a comment. In D67583#1678505 , @labath wrote: > This will work for the python-in-lldb case. However, the idea is lldb can > also be used as python package, from any python application (by just typing > `import lldb`). For that to work, we ne

[Lldb-commits] [PATCH] D67583: Fix swig python package path

labath added a comment. In D67583#1677141 , @hhb wrote: > In D67583#1676531 , @labath wrote: > > > Since I'm already complaining about python paths, I'll add that the way we > > currently compute the python path is

[Lldb-commits] [PATCH] D67583: Fix swig python package path

ZeGentzy added a comment. In D67583#1676531 , @labath wrote: > I could be off mark here, but I do recall some people trying to get this code > to work in environments where python and lldb(llvm) are configured with > different libdirs (so LLVM_LIBDIR_SUF

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1676531 , @labath wrote: > I could be off mark here, but I do recall some people trying to get this code > to work in environments where python and lldb(llvm) are configured with > different libdirs (so LLVM_LIBDIR_SUFFIX i

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1675889 , @ZeGentzy wrote: > In D67583#1675714 , @hhb wrote: > > > My theory now is that your python has a different implementation of > > get_python_lib(). After all we should not gu

[Lldb-commits] [PATCH] D67583: Fix swig python package path

labath added a comment. I could be off mark here, but I do recall some people trying to get this code to work in environments where python and lldb(llvm) are configured with different libdirs (so LLVM_LIBDIR_SUFFIX in llvm, and `configure --prefix=X` in python). Is that the case you're running

[Lldb-commits] [PATCH] D67583: Fix swig python package path

ZeGentzy added a comment. In D67583#1675714 , @hhb wrote: > My theory now is that your python has a different implementation of > get_python_lib(). After all we should not guess what python would do. I'm > making a change. > If you still interested in t

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1675697 , @ZeGentzy wrote: > In D67583#1675415 , @hhb wrote: > > > Oh sorry my mistake. The current directory should be > > llvm-project/lldb/scripts. I.e. > > > > cd /src/llvm-proj

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. I'm making a change in finishSwigPythonLLDB.py to write directly to targetDir. This way we don't have the problem to guess where the files are written. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583

[Lldb-commits] [PATCH] D67583: Fix swig python package path

ZeGentzy added a comment. In D67583#1675415 , @hhb wrote: > Oh sorry my mistake. The current directory should be > llvm-project/lldb/scripts. I.e. > > cd /src/llvm-project/lldb/scripts > Maybe I'm doing something wrong, but that does not work either.

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. Oh sorry my mistake. The current directory should be llvm-project/lldb/scripts. I.e. cd /src/llvm-project/lldb/scripts Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583

[Lldb-commits] [PATCH] D67583: Fix swig python package path

ZeGentzy added a comment. In D67583#1674912 , @hhb wrote: > I don't have the right environment to try your command. But I didn't see > anything obviously problematic. > > Can you try the following: > > cd /src/llvm-project/lldb/scripts/Python > > > Then

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. +deepak2427 since this behavior is introduced in https://github.com/llvm/llvm-project/commit/9b35cf52d2a88cda5167c9638696adce5b152720 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. I don't have the right environment to try your command. But I didn't see anything obviously problematic. Can you try the following: cd /src/llvm-project/lldb/scripts/Python Then run the following python program: import sys sys.path.append('/src/llvm-project/lldb/scr

[Lldb-commits] [PATCH] D67583: Fix swig python package path

ZeGentzy added a comment. That's odd > Can you share your full compile command and environment? I'm using this PKGBUILD: https://github.com/ZeGentzy/aur-buildscripts/blob/master/llvm-git-gentz/PKGBUILD#L376 The commands being run are these: export PKG_CONFIG_PATH="/usr/lib32/pkgconfig"

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1674430 , @hhb wrote: > In D67583#1673356 , @ZeGentzy wrote: > > > Hello folks, > > > > These changes break running `ninja install` when building with `-D > > LLVM_LIBDIR_SUFFIX=32`.

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1673356 , @ZeGentzy wrote: > Hello folks, > > These changes break running `ninja install` when building with `-D > LLVM_LIBDIR_SUFFIX=32`. > > [...] > -- Up-to-date: > /build/llvm-git-gentz/pkg/lib32-llvm-git-gentz/opt/

[Lldb-commits] [PATCH] D67583: Fix swig python package path

ZeGentzy reopened this revision. ZeGentzy added a comment. This revision is now accepted and ready to land. Hello folks, These changes break running `ninja install` when building with `-D LLVM_LIBDIR_SUFFIX=32`. [...] -- Up-to-date: /build/llvm-git-gentz/pkg/lib32-llvm-git-gentz/opt/llvm32

[Lldb-commits] [PATCH] D67583: Fix swig python package path

This revision was automatically updated to reflect the committed changes. Closed by commit rL372047: Fix swig python package path (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D67583?vs=

[Lldb-commits] [PATCH] D67583: Fix swig python package path

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583 ___

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb updated this revision to Diff 220392. hhb added a comment. Use CMAKE_HOST_SYSTEM_NAME instead. Since the python script is run on host. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583 Files: lldb/scrip

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb updated this revision to Diff 220206. hhb added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583 Files: lldb/scripts/CMakeLists.txt Index: lldb/scripts/CMakeLists.txt ==

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb updated this revision to Diff 220207. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583 Files: lldb/scripts/CMakeLists.txt Index: lldb/scripts/CMakeLists.txt ==

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. The path defined in CMakeLists.txt doesn't match the path generated in our python script. This change fixes that. LLVM_LIBRARY_OUTPUT_INTDIR is defined as: ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INT