labath added a comment. In D67583#1677141 <https://reviews.llvm.org/D67583#1677141>, @hhb wrote:
> In D67583#1676531 <https://reviews.llvm.org/D67583#1676531>, @labath wrote: > > > Since I'm already complaining about python paths, I'll add that the way we > > currently compute the python path is wrong for cross-compilation. (Because > > it will pick up the path from the host python, not the target one.) If > > we're going to be changing something here, it would be nice to fix that too > > (which, I hope, will also allow us avoid needing to keep multiple places in > > sync). > > > I also realized that this is totally wrong for cross-compilation. We are > doing cross compilation to windows with MinGW so I need to fix that. > > Actually I don't know why we need get_python_lib(). From what I can see now, > the 3 paths should match: > > 1. finishSwigPythonLLDB.py write necessary files to > ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/distutils.sysconfig.get_python_lib() > 2. lldb/scripts/CMakeLists.txt copies them to lib${LLVM_LIBDIR_SUFFIX} (if > not xcode) > 3. ScriptInterpreterPython.cpp adds the right path into PYTHONPATH. > > As long as these 3 paths matches, we are good. Then why not simply put > everything into ${liblldb path}/site-packages for all platforms? > > (I'm gonna make a change to test that. But let me know if anything is > obviously wrong. This will work for the python-in-lldb case. However, the idea is lldb can also be used as python package, from any python application (by just typing `import lldb`). For that to work, we need to install lldb python stuff to a location that will be searched for by python in its default configuration. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
