This revision was automatically updated to reflect the committed changes.
Closed by commit rL371668: [DWARF] Evaluate DW_OP_entry_value (authored by
vedantk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D67376?vs=219779&id=219804#toc
Repository:
rL LLVM
CHANGES SINCE LA
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Thanks, that's exactly what I was looking for!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67376/new/
https://reviews.llvm.org/D67376
__
vsk added inline comments.
Comment at: lldb/include/lldb/Symbol/Function.h:258
+
+using CallSiteParameterArray = std::unique_ptr>;
+
aprantl wrote:
> vsk wrote:
> > vsk wrote:
> > > aprantl wrote:
> > > > vsk wrote:
> > > > > grandinj wrote:
> > > > > > the way t
vsk updated this revision to Diff 219779.
vsk marked 3 inline comments as done.
vsk added a comment.
- Add a working example and some additional comments in
Evaluate_DW_OP_entry_value.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67376/new/
https://reviews.llvm.org/D67376
Files:
ll
aprantl added inline comments.
Comment at: lldb/source/Expression/DWARFExpression.cpp:497
+
+ finish_subexpressions_to(end_offset);
}
labath wrote:
> aprantl wrote:
> > We should probably just let llvm's libDebugInfo do the printing here, but
> > this works fi
aprantl added a comment.
Looking great! I have one more question inline, but that is mostly about
documenting the algorithm.
Comment at: lldb/include/lldb/Symbol/Function.h:258
+
+using CallSiteParameterArray = std::unique_ptr>;
+
vsk wrote:
> vsk wrote:
> > a
labath added inline comments.
Comment at: lldb/source/Expression/DWARFExpression.cpp:497
+
+ finish_subexpressions_to(end_offset);
}
aprantl wrote:
> We should probably just let llvm's libDebugInfo do the printing here, but
> this works fine for now.
FYI: I ha
vsk added inline comments.
Comment at: lldb/include/lldb/Symbol/Function.h:258
+
+using CallSiteParameterArray = std::unique_ptr>;
+
vsk wrote:
> aprantl wrote:
> > vsk wrote:
> > > grandinj wrote:
> > > > the way this is being used seems to indicate it can be
>
vsk updated this revision to Diff 219648.
vsk marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67376/new/
https://reviews.llvm.org/D67376
Files:
lldb/include/lldb/Symbol/Function.h
lldb/packages/Python/lldbsuite/test/decorators.py
lldb/packages/Pytho
vsk added inline comments.
Comment at: lldb/include/lldb/Symbol/Function.h:258
+
+using CallSiteParameterArray = std::unique_ptr>;
+
aprantl wrote:
> vsk wrote:
> > grandinj wrote:
> > > the way this is being used seems to indicate it can be
> > >std::vector
vsk updated this revision to Diff 219646.
vsk marked 4 inline comments as done.
vsk added a comment.
- Fix return address lookup when the immediate parent frame is inlined.
- Tighten the test so that it actually verifies that tail calls, inlining, etc.
occur, instead of assuming :).
- Add/move va
aprantl added inline comments.
Comment at: lldb/include/lldb/Symbol/Function.h:258
+
+using CallSiteParameterArray = std::unique_ptr>;
+
vsk wrote:
> grandinj wrote:
> > the way this is being used seems to indicate it can be
> >std::vector
> > no need for un
vsk planned changes to this revision.
vsk marked an inline comment as done.
vsk added a comment.
While tightening up the test case I think I found an issue with the way inlined
frames are handled. I need to take a closer look.
Comment at: lldb/include/lldb/Symbol/Function.h:25
grandinj added inline comments.
Comment at: lldb/include/lldb/Symbol/Function.h:258
+
+using CallSiteParameterArray = std::unique_ptr>;
+
the way this is being used seems to indicate it can be
std::vector
no need for unique_ptr
CHANGES SINCE LAST ACTION
h
vsk marked an inline comment as done.
vsk added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3752
+LocationInCaller = parse_simple_location(i);
+break;
+ }
aprantl wrote:
> vsk wrote:
> > aprantl wrote
vsk updated this revision to Diff 219573.
vsk marked an inline comment as done.
vsk edited the summary of this revision.
vsk added a comment.
- Addressed review feedback, split out unrelated changes, and improved test
coverage.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67376/new/
h
aprantl added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3752
+LocationInCaller = parse_simple_location(i);
+break;
+ }
vsk wrote:
> aprantl wrote:
> > default?
> I don't believe any action is needed
vsk planned changes to this revision.
vsk added a comment.
TODO:
- Split out llvm change.
- Add a test to validate that lldb skips inline frames when evaluating
DW_OP_entry_value.
Comment at:
lldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_va
vsk updated this revision to Diff 219462.
vsk marked 7 inline comments as done.
vsk added a comment.
- Partially address review feedback.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67376/new/
https://reviews.llvm.org/D67376
Files:
lldb/include/lldb/Symbol/Function.h
lldb/include
aprantl added a comment.
This is very exciting!
Comment at:
lldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values/Makefile:4
+include $(LEVEL)/Makefile.rules
+CXXFLAGS += -g -O1 -glldb -Xclang -femit-debug-entry-values
The -g
vsk updated this revision to Diff 219442.
vsk added a comment.
- Clean up the test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67376/new/
https://reviews.llvm.org/D67376
Files:
lldb/include/lldb/Symbol/Function.h
lldb/packages/Python/lldbsuite/test/decorators.py
lldb/packages
vsk created this revision.
vsk added reviewers: aprantl, friss, jasonmolenda, jingham.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.
Add support for evaluating DW_OP_entry_value. This involves:
- Teaching clang to emit debug entry values when the debugger tuning
22 matches
Mail list logo
