vsk marked an inline comment as done. vsk added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3752 + LocationInCaller = parse_simple_location(i); + break; + } ---------------- aprantl wrote: > vsk wrote: > > aprantl wrote: > > > default? > > I don't believe any action is needed in the default case: we do not want to > > log or report an error. > Doesn't this trigger the switch-doesn't-cover-all-cases warning otherwise? No warning because dw_attr_t is a uint16_t, but it's probably simpler to avoid the switch here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67376/new/ https://reviews.llvm.org/D67376 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
