[Lldb-commits] [PATCH] D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option

stella.stamenova added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:318 + if(MSVC) +set(flag_werror "/WX") + endif() sgraenitz wrote: > I copied the flag from LLVM. Is it the right one for MSVC? Yes: https://docs.microsoft.com/en-us/cpp/

[Lldb-commits] [PATCH] D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option

sgraenitz abandoned this revision. sgraenitz added a comment. In D65939#1620780 , @labath wrote: > So, why doesn't LLVM_ENABLE_WERROR suffice? It looks like that ought to work > even in standalone builds... LLVM_ENABLE_WERROR affects the entire build tr

[Lldb-commits] [PATCH] D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option

labath added a comment. So, why doesn't LLVM_ENABLE_WERROR suffice? It looks like that ought to work even in standalone builds... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65939/new/ https://reviews.llvm.org/D65939 _

[Lldb-commits] [PATCH] D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option

sgraenitz added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:318 + if(MSVC) +set(flag_werror "/WX") + endif() I copied the flag from LLVM. Is it the right one for MSVC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option

sgraenitz created this revision. sgraenitz added reviewers: teemperor, JDevlieghere, davide, labath, stella.stamenova. Herald added a subscriber: mgorny. Herald added a project: LLDB. Treat warnings as errors all over LLDB when enabled. Defaults to `OFF`. Repository: rG LLVM Github Monorepo