This revision was automatically updated to reflect the committed changes.
Closed by commit rL354283: [Reproducers] Make clang use lldb's VFS.
(authored by JDevlieghere, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://review
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
LGTM as long as we always set a custom module cache path.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58309/new/
https://reviews.llvm.org/D58309
___
JDevlieghere updated this revision to Diff 187116.
JDevlieghere added a comment.
- Have lldb use a custom module cache and remove it before replaying the
reproducer.
- Remove the cocoa test now that we have a capture and replay test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58309/n
aprantl added inline comments.
Comment at: lldb/lit/Reproducer/Modules/TestModuleCXX.test:17
+# Capture the debug session.
+# RUN: %lldb -x -b -s %S/Inputs/ModuleCXX.in --capture %t.repro %t.root/a.out
| FileCheck %s --check-prefix CAPTURE
+# CAPTURE: (success = 0)
-
JDevlieghere updated this revision to Diff 187101.
JDevlieghere added a comment.
- Code review feedback Adrian
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58309/new/
https://reviews.llvm.org/D58309
Files:
lldb/include/lldb/Host/FileSystem.h
lldb/include/lldb/Symbol/ClangASTImport
aprantl added inline comments.
Comment at: lldb/lit/Reproducer/Modules/Inputs/main.cpp:5
+ Foo foo;
+ // break here.
+ return 0;
This is not very robust, since there is no code on this line. Personally I'd
use:
```
void stop() {}
int main(int argc, char **a
JDevlieghere created this revision.
JDevlieghere added reviewers: aprantl, clayborg, zturner, davide.
JDevlieghere added a project: LLDB.
Herald added subscribers: jdoerfert, teemperor.
In r353906 we hooked up clang and lldb's reproducer infrastructure to
capture files used by clang. This patch ad
