[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

labath added a comment. Thank you for reviewing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58177/new/ https://reviews.llvm.org/D58177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

This revision was automatically updated to reflect the committed changes. Closed by commit rL354106: Fix lldb-server test suite for python3 (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. In D58177#1397873 , @labath wrote: > Thanks for the review Stella. I was hoping someone would step in and tell me > that there is a

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

labath updated this revision to Diff 186823. labath marked an inline comment as done. labath added a comment. - rename the string conversion functions and explain their operation in more detail - add "from __future__ import division" to ensure consistency between python versions CHANGES SINCE

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

labath added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py:415 # Add zero-fill to the right/end (MSB side) of the value. -retval += "00" * (byte_size - len(retval) / 2) +retval += "00" * (

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

labath added a comment. Thanks for the review Stella. I was hoping someone would step in and tell me that there is a better way to do that. However :), I see two problems with your proposal: - build.py is a standalone file, and so it is not easy for it to share code with other stuff. This can

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

stella.stamenova requested changes to this revision. stella.stamenova added inline comments. This revision now requires changes to proceed. Comment at: packages/Python/lldbsuite/support/seven.py:28 + +def bytes_to_string(b): +"""Take a string(PY2) or a bytes(PY3) object and r

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58177/new/ https://reviews.llvm.org/D58177 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

serge-sans-paille added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py:415 # Add zero-fill to the right/end (MSB side) of the value. -retval += "00" * (byte_size - len(retval) / 2) +retval

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

labath created this revision. labath added reviewers: davide, zturner. Herald added a reviewer: serge-sans-paille. This patch finishes the python3-ification of the lldb-server test suite. It reverts the partial attempt in r352709 to encode/decode the string via utf8 before writing to the socket. T