[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

shafik added a comment. In D57413#1376280 , @davide wrote: > To clarify, I think we ought to fix the UB regardless, but Zachary's change > can go in anyway as it doesn't make the situation worse than it was before. It does not, I was more comment on the

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB352557: Fix some warnings in building LLDB. (authored by zturner, committed by ). Herald added a subscriber: abidh. Changed prior to commit: https://reviews.llvm.org/D57413?vs=184163&id=184186#toc R

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

davide added a comment. To clarify, I think we ought to fix the UB regardless, but Zachary's change can go in anyway as it doesn't make the situation worse than it was before. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57413/new/ https://reviews.llvm.org/D57413 __

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

davide added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:789-792 + assert(encodedBits.repr.unused == 0); + decodedBits.repr.sign = encodedBits.repr.sign; + decodedBits.repr.fraction = encodedBits.repr.fraction; + decodedBits.repr.exponent = decode

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Ah, missed that. Whoever was probably just copying down the way the struct was defined internally in Foundation... This seems fine then - assuming Target & Host have the same endianness i

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

shafik added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:789-792 + assert(encodedBits.repr.unused == 0); + decodedBits.repr.sign = encodedBits.repr.sign; + decodedBits.repr.fraction = encodedBits.repr.fraction; + decodedBits.repr.exponent = decode

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

zturner marked an inline comment as done. zturner added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/NSDictionary.cpp:304-314 -union { - struct { -uint64_t _mutations; - }; - struct { -uint32_t _muts; -uint32_t _used:25

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

davide added a comment. the changes that touch code I wrote lgtm. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:789-792 + assert(encodedBits.repr.unused == 0); + decodedBits.repr.sign = encodedBits.repr.sign; + decodedBits.repr.fraction = encodedBits.repr.fraction;

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

zturner marked an inline comment as done. zturner added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/NSDictionary.cpp:304-314 -union { - struct { -uint64_t _mutations; - }; - struct { -uint32_t _muts; -uint32_t _used:25

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I don't think the data formatter changes are right. Looks like whoever wrote these data formatters was directly reading target memory onto a host sized struct, expecting everythin

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Zachary, this LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57413/new/ https://reviews.llvm.org/D57413 ___ lldb

[Lldb-commits] [PATCH] D57413: Fix some warnings with gcc on Linux

zturner created this revision. zturner added reviewers: davide, JDevlieghere, jingham. Most of these are surrounding the ObjectiveC formatters. They use a lot of unions containing unnamed structs, which are not ISO C++ compliant and which gcc warns about. There are several other minor warnings