[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353271: [Reproducers] lldb-instr: tool to generate instrumentation macros. (authored by JDevlieghere, committed by ). Herald added a reviewer: serge-sans-paille. Herald added a project: LLDB. Changed p

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

JDevlieghere updated this revision to Diff 185434. JDevlieghere added a comment. - Use new LLDB_ prefix - Insert two newlines at the end of the macro, so clang-format fixes it up consistently. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56822/new/ https://reviews.llvm.org/D56822 Fil

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

JDevlieghere added a comment. It doesn't really make sense to land this without the SBReproducer framework, so I'll leave it open until that gets accepted as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56822/new/ https://reviews.llvm.org/D56822 __

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

JDevlieghere updated this revision to Diff 184392. JDevlieghere added a comment. - Skip decls that have a canonical decl in the implementation file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56822/new/ https://reviews.llvm.org/D56822 Files: tools/CMakeLists.txt tools/sbrepro/CM

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. ok, looks good then CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56822/new/ https://reviews.llvm.org/D56822 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

JDevlieghere added a comment. In D56822#1376770 , @labath wrote: > So, if I understand this correctly, a constructor like `SBFoo::SBFoo(){}` > will not be considered for macroization because it's empty? That doesn't > sound right to me. Even an empty con

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

labath added a comment. So, if I understand this correctly, a constructor like `SBFoo::SBFoo(){}` will not be considered for macroization because it's empty? That doesn't sound right to me. Even an empty constructor has a side effect of constructing the object, which is something that I would e

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

JDevlieghere updated this revision to Diff 184210. JDevlieghere added a comment. - Use join from StringExtras. - Rename Skip to ShoupdSkip and document its cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56822/new/ https://reviews.llvm.org/D56822 Files: tools/CMakeLists.txt to

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

labath added inline comments. Comment at: tools/sbrepro/SBRepro.cpp:22-31 +static std::string Join(const std::vector &V) { + std::string Str; + llvm::raw_string_ostream OS(Str); + for (std::size_t I = 0, E = V.size(); I < E; ++I) { +OS << V[I]; +if (I != E - 1) +

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

JDevlieghere updated this revision to Diff 183888. JDevlieghere added reviewers: labath, davide, friss. JDevlieghere added a comment. Fix `MacroMacro` and other code cleanups. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56822/new/ https://reviews.llvm.org/D56822 Files: tools/CMakeL

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

labath added a comment. Is this ready for review now? Comment at: tools/sbrepro/SBRepro.cpp:98 + +static std::string GetRegisterConstructorMacroMacro(StringRef Class, +StringRef Signature) { `MacroMacro`? CH

[Lldb-commits] [PATCH] D56822: [Reproducers] Tool to insert SBReproducer macros

JDevlieghere updated this revision to Diff 183584. JDevlieghere retitled this revision from "[WIP] Tool to insert SBReproducer macros" to "[Reproducers] Tool to insert SBReproducer macros". JDevlieghere added a comment. Fixed printing of booleans; the tool would show `_Bool` instead of `bool`. I