[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

This revision was automatically updated to reflect the committed changes. Closed by commit rL349767: Overload GetMemoryRegions for the ProcessMinidump (authored by tkrasnukha, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55841?vs=17

[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55841/new/ https://reviews.llvm.org/D55841 ___ l

[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

tatyana-krasnukha updated this revision to Diff 178931. tatyana-krasnukha added a comment. Removed dump file from the patch Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55841/new/ https://reviews.llvm.org/D55841 Files: packages/Python/lldbsuite/test/functi

[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just remove the "regions-linux-map.dmp" as I already checked one in with rLLDB349658 and this is good to go Comment at:

[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

clayborg added a comment. In D55841#1336519 , @clayborg wrote: > In D55841#1336515 , > @tatyana-krasnukha wrote: > > > Add a test > > > There was one added. See code Never mind, I thought this was my patch! Ignor

[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

clayborg added a comment. In D55841#1336515 , @tatyana-krasnukha wrote: > Add a test There was one added. See code Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55841/new/ https://reviews.llvm.org/D55841 _

[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

tatyana-krasnukha updated this revision to Diff 178916. tatyana-krasnukha added a comment. Add a test Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55841/new/ https://reviews.llvm.org/D55841 Files: packages/Python/lldbsuite/test/functionalities/postmortem/m

[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Change looks good. We need to add a test for this. You can use the minidump file from "lldb/unittests/Process/minidump/Inputs/regions-linux-map.dmp" and copy it over into "lldb

[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: clayborg. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. Moved from D55472 Repository: rLLDB LLDB https://reviews.llvm.org/D55841 Files: C:/Rep