clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed.
Change looks good. We need to add a test for this. You can use the minidump file from "lldb/unittests/Process/minidump/Inputs/regions-linux-map.dmp" and copy it over into "lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new" and then add a test to "packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py" to ensure this doesn't regress. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55841/new/ https://reviews.llvm.org/D55841 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
