[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rGfaf6b2543e47: [ARC] Basic support in gdb-remote process plugin (authored by tatyana-krasnukha). Changed prior to commit: https://reviews.llvm.org/D55718?vs=225432&id=225437#toc Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 225432. tatyana-krasnukha added a comment. Herald added a subscriber: wuzish. Removed any ARC-specific logic from the ProcessGDBRemote.cpp. It seems, there is nothing to test now;) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

JDevlieghere added a comment. In D55718#1453084 , @tatyana-krasnukha wrote: > Hi, currently we have a private build server that executes the test-suite on > ARC. There are failures for now, mostly due to unimplemented features for ARC > like expressions

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added a comment. Hi, currently we have a private build server that executes the test-suite on ARC. There are failures for now, mostly due to unimplemented features for ARC like expressions support. I'll take care of a public build-bot, if it is required. Repository: rLLDB L

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

JDevlieghere added a comment. Hey Tatyana, what's the plan with regards to testing this? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added a comment. In D55718#1443560 , @labath wrote: > TBE, the best way would be no not even hardcode that info but ask llvm about > these things. `llvm::MCRegisterInfo` doesn't provide us with all necessary fields to create a full `R

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added a comment. In D55718#1443415 , @jasonmolenda wrote: > Back in 2015 I added some code in r247121 that would fill in eh_frame and > dwarf register numbers from the ABI plugin if the remote stub didn't provide > them in ProcessGDBRe

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

labath added a comment. In D55718#1443487 , @clayborg wrote: > As long as the numbers _can_ still come from the GDB server, I am all for > that. If they are not supplied, then we use arch defaults. That allows new > system/arch bringups where the info mi

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

jasonmolenda added a comment. In D55718#1443487 , @clayborg wrote: > As long as the numbers _can_ still come from the GDB server, I am all for > that. If they are not supplied, then we use arch defaults. That allows new > system/arch bringups where the i

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

clayborg added a comment. As long as the numbers _can_ still come from the GDB server, I am all for that. If they are not supplied, then we use arch defaults. That allows new system/arch bringups where the info might be changing often, and also allows the info to be locked down. The architectur

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

labath added a comment. In D55718#1443415 , @jasonmolenda wrote: > In D55718#1442965 , @clayborg wrote: > > > It would be really nice to get the GDB remote server for ARC so that it > > vends the correct regs to b

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

jasonmolenda added a comment. In D55718#1442965 , @clayborg wrote: > It would be really nice to get the GDB remote server for ARC so that it vends > the correct regs to begin with, but if that isn't possible I guess we need to > do what we are doing here

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

clayborg added a comment. It would be really nice to get the GDB remote server for ARC so that it vends the correct regs to begin with, but if that isn't possible I guess we need to do what we are doing here. I would really like to not see more architectures have to add code to ProcessGDBRemote

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added a comment. Herald added a subscriber: jdoerfert. Kind reminder. I believe all discussions have been resolved. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 ___

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 184586. tatyana-krasnukha removed a subscriber: llvm-commits. tatyana-krasnukha added a comment. Changed configuration register handling logic: if an RSP-server doesn't provide a register, don't count this as a failure - just use default values for

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 183310. tatyana-krasnukha added a comment. Updated new file headers to reflect the new license Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 Files: include/lldb/Core/A

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 183301. tatyana-krasnukha added a comment. Herald added subscribers: jsji, atanasyan, kbarton, nemanjai, sdardis. Moved ARC flags enum inside the `ArchitectureArc` class; Made `OverrideStopInfo` with empty body instead of being pure virtual. If this

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added inline comments. Comment at: source/Plugins/Architecture/Arc/ArchitectureArc.cpp:1-8 +//===-- ArchitectureArc.cpp -*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// This file is distri

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

clayborg added inline comments. Comment at: source/Plugins/Architecture/Arc/ArchitectureArc.cpp:1-8 +//===-- ArchitectureArc.cpp -*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed und

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 183110. tatyana-krasnukha added a comment. Herald added a subscriber: llvm-commits. Addressed comments Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 Files: include/lldb/C

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: include/lldb/Core/Architecture.h:119-123 + virtual std::vector + ConfigurationRegisterNames() const { return {}; } + + using ConfigurationReg

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 182848. tatyana-krasnukha added a comment. Keep trying to hide the processor's specifics from the ProcessGDBRemote Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 Files:

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added inline comments. Comment at: source/Plugins/Architecture/Arc/ArchitectureArc.cpp:29 + PluginManager::RegisterPlugin(GetPluginNameStatic(), +"ARC-specific algorithms", +&ArchitectureArc::Creat

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added a comment. Why `lldb_private::Flags` is required? `std::bitset` provides the same functionality and even more. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 _

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:1222-1223 + + if (!arch_plugin->SetFeatures(reg_reader) && log) +log->PutCString("Failed to set architecture features"); + clayborg wrot

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: include/lldb/Core/Architecture.h:118-127 + static constexpr uint8_t max_features_count = 32u; + virtual std::bitset GetFeatures() const { retu

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 182499. tatyana-krasnukha added a comment. After all, I moved ARC configuring routines to the ArchitechtureArc plug-in. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 Fil

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

clayborg added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4707 if (comm.GetQXferLibrariesSVR4ReadSupported()) { list.clear(); My two cents: I fully support a stub being able to provide the register info for DWAR

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 182325. tatyana-krasnukha added a comment. Removed registers adjustment, dwarf numbers are corrected by AugmentRegisterInfoViaABI now. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha marked an inline comment as not done. tatyana-krasnukha added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4707 +else + // The register info is incorrect, just clear it. + m_register_info.Clear();

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

labath added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4707 +else + // The register info is incorrect, just clear it. + m_register_info.Clear(); tatyana-krasnukha wrote: > clayborg wrote: > > Is

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha marked an inline comment as done. tatyana-krasnukha added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4707 +else + // The register info is incorrect, just clear it. + m_register_info.Clear();

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

clayborg added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4707 +else + // The register info is incorrect, just clear it. + m_register_info.Clear(); Is this a GDB server that you can modify? Or is

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added a comment. Friendly ping. I would like to have this in the nearest release. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 178933. tatyana-krasnukha added a comment. Clear `m_register_info` if it is incorrect. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 Files: include/lldb/Utility/ArchSp

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4707 + +arc::AdjustRegisterInfo(m_register_info, arch_to_use); } clayborg wrote: > ok, makes sense. Clearing the register info would be a go

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

clayborg added a comment. In D55718#1336045 , @tatyana-krasnukha wrote: > `ARCflags` are used by ABISysV_arc (related patch D55724 > ). I would be glad to move it to > architecture plugin, but I ought to add SetFlags/Get

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha marked an inline comment as not done. tatyana-krasnukha added a comment. `ARCflags` are used by ABISysV_arc (related patch D55724 ). I would be glad to move it to architecture plugin, but I ought to add SetFlags/GetFlags to Architecture interfac

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

clayborg added a comment. See inline comments and let me know what you think. Comment at: include/lldb/Utility/ArchSpec.h:91-92 + // ARC configuration flags + enum ARCflags { eARC_rf32 = 0 /*0b00*/, eARC_rf16 = 2 /*0b10*/ }; + Since no other place needs the

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 178643. tatyana-krasnukha added a comment. Addressed review comments Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 Files: include/lldb/Utility/ArchSpec.h source/Plug

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha marked 2 inline comments as done. tatyana-krasnukha added a comment. My intent was to move ARC-specific code to the architecture plugin as much as possible, but it requires to add undesired dependencies to Architecture interface. So, you are right, it seems to be better to keep

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. It would be nice to see context when you submit diffs. with SVN: svn diff -x -U999 ... Or git: git diff -U999 Comment at: include/lldb/Core/Archi

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: clayborg, jasonmolenda. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, mgorny. Add ARC architecture (bare-metal) that can be debugged through an RSP-server. Repository: rLLDB LLDB htt