[Lldb-commits] [PATCH] D55584: [LLDB] Simplify Boolean expressions

shafik accepted this revision as: shafik. shafik added a comment. LGTM after comment are addressed. Comment at: source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:5894 +if (!success) { + offset = MachHeaderSizeFromMagic(m_header.magic); + for (uint32_t i = 0; !s

[Lldb-commits] [PATCH] D55584: [LLDB] Simplify Boolean expressions

JDevlieghere added a comment. In D55584#1328087 , @labath wrote: > I also find the `static_cast` thingy weird. The rest of the changes > seem to be towards the better (based on a pseudo-random sample), but the > change is a quite big. Me and Adrian wen

[Lldb-commits] [PATCH] D55584: [LLDB] Simplify Boolean expressions

labath added a comment. I also find the `static_cast` thingy weird. The rest of the changes seem to be towards the better (based on a pseudo-random sample), but the change is a quite big. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55584/new/ https://reviews.llvm.org/D55584 _

[Lldb-commits] [PATCH] D55584: [LLDB] Simplify Boolean expressions

Eugene.Zelenko added a comment. Thank you for cleanup effort! I would suggest to also run modernize checks and at least next readability checks: readability-container-size-empty readability-isolate-declaration readability-redundant-control-flow readability-redundant-member-init readability-redu