JDevlieghere added a comment.

In D55584#1328087 <https://reviews.llvm.org/D55584#1328087>, @labath wrote:

> I also find the `static_cast<bool>` thingy weird. The rest of the changes 
> seem to be towards the better (based on a pseudo-random sample), but the 
> change is a quite big.


Me and Adrian went through all the changes and I didn't see anything that 
looked out of the ordinary.

I left the static cast because it was suggested to me before in a review, but 
happy to remove it as there is a consensus that it's worse :-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55584/new/

https://reviews.llvm.org/D55584



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to