This revision was automatically updated to reflect the committed changes.
Closed by commit rL348287: [FileSystem] Migrate CommandCompletions (authored by
JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D55240?vs=176525&id=
JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.
Comment at: source/Commands/CommandCompletions.cpp:180
+ FileSystem fs = FileSystem::Instance();
std::error_code EC;
labath wrote:
> This should surely be a reference, no? Ma
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good, modulo the filesystem copy comment.
Comment at: source/Commands/CommandCompletions.cpp:180
+ FileSystem fs = FileSystem::Instance();
std::error_code EC;
---
JDevlieghere updated this revision to Diff 176525.
JDevlieghere added a comment.
Initialize the FS in the unit test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55240/new/
https://reviews.llvm.org/D55240
Files:
include/lldb/Host/FileSystem.h
source/Commands/CommandCompletions.cpp
davide added a comment.
No objections from me, but I would appreciate if @labath can take a look.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55240/new/
https://reviews.llvm.org/D55240
___
lldb-commits mailing li
JDevlieghere created this revision.
JDevlieghere added reviewers: davide, labath.
JDevlieghere added a project: LLDB.
Make use of the convenience helpers from FileSystem.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D55240
Files:
include/lldb/Host/FileSystem.h
source/Commands/CommandC
