JDevlieghere marked an inline comment as done. JDevlieghere added inline comments.
================ Comment at: source/Commands/CommandCompletions.cpp:180 + FileSystem fs = FileSystem::Instance(); std::error_code EC; ---------------- labath wrote: > This should surely be a reference, no? Making a copy of a filesystem sounds > weird (and should probably be forbidden by deleting the copy constructor). Correct, this is a typo but shouldn't compile. I'll include the fix when landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55240/new/ https://reviews.llvm.org/D55240 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
