This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rL348592: Introduce ObjectFileBreakpad (authored by labath,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.
labath marked 3 inline comments as done.
labath added inline comments.
Comment at: source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.h:74
+
+ bool IsStripped() override { return false; }
+
markmentovai wrote:
> labath wrote:
> > zturner wrote:
> > > Is this
markmentovai added inline comments.
Comment at: source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.h:74
+
+ bool IsStripped() override { return false; }
+
labath wrote:
> zturner wrote:
> > Is this always true for breakpad files?
> Well.. the whole point of t
labath added inline comments.
Comment at: lit/Modules/Breakpad/lit.local.cfg:1
+config.suffixes = ['.test']
zturner wrote:
> This shouldn't be necessary, the top-level `lit.cfg.py` already recognizes
> `.test` extension. You only need a lit.local.cfg if you're
labath updated this revision to Diff 176781.
labath marked 17 inline comments as done.
labath added a comment.
Updated according to review comments.
Also added a couple of tests for invalid inputs.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55214/new/
https://reviews.llvm.org/D55214
zturner added inline comments.
Comment at: lit/Modules/Breakpad/lit.local.cfg:1
+config.suffixes = ['.test']
This shouldn't be necessary, the top-level `lit.cfg.py` already recognizes
`.test` extension. You only need a lit.local.cfg if you're changing something
lemo accepted this revision.
lemo added a comment.
Looks like a great start
Comment at: source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp:53
+ static_assert(sizeof(data) == 20, "");
+ if (str.size() < 33 || str.size() > 40)
+return UUID();
these m
labath added a reviewer: markmentovai.
labath marked 3 inline comments as done.
labath added inline comments.
Comment at: source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp:66-84
+ if (os == llvm::Triple::Win32) {
+// In binary form, the module id should have 20 bytes
labath updated this revision to Diff 176615.
labath added a comment.
- implement the module_id/code_id logic suggested by Mark Mentovai
- fix module_id endianness handling to make sure the UUID matches the one we
get from the minidump files
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
markmentovai added a comment.
Very excited to see this work beginning!
Comment at: source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp:66-84
+ if (os == llvm::Triple::Win32) {
+// In binary form, the module id should have 20 bytes: 16 bytes for UUID,
+// and 4 by
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
This looks like a good start.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55214/new/
https://reviews.llvm.org/D55214
___
lldb-comm
labath added inline comments.
Comment at: source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp:66-84
+ if (os == llvm::Triple::Win32) {
+// In binary form, the module id should have 20 bytes: 16 bytes for UUID,
+// and 4 bytes for the "age". However, in the textual
labath created this revision.
labath added reviewers: clayborg, zturner, lemo, amccarth.
Herald added subscribers: fedor.sergeev, mgorny.
This patch adds the scaffolding necessary for lldb to recognise symbol
files generated by breakpad. These (textual) files contain just enough
information to be
13 matches
Mail list logo
