labath added inline comments.
================
Comment at: source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp:66-84
+ if (os == llvm::Triple::Win32) {
+ // In binary form, the module id should have 20 bytes: 16 bytes for UUID,
+ // and 4 bytes for the "age". However, in the textual format, the 4 bytes
of
+ // age are printed via %x, which can lead to shorter strings. So, we pad
the
+ // string with zeroes after the 16 bytes, to obtain a string of appropriate
+ // size.
+ if (token.size() < 33 || token.size() > 40)
----------------
@lemo: Does this part make sense? It seems that on linux the breakpad files
have the `INFO CODE_ID` section, which contains the UUID without the funny
trailing zero. So I could try fetching the UUID from there instead, but only on
linux, as that section is not present mac (and on windows it contains something
completely different). Right now I compute the UUID on linux by chopping off
the trailing zero (as I have to do that anyway for mac), but I could do
something different is there's any advantage to that.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55214/new/
https://reviews.llvm.org/D55214
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
