[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

This revision was automatically updated to reflect the committed changes. Closed by commit rL347305: [CMake] Streamline code signing for debugserver and pass entitlements to… (authored by stefan.graenitz, committed by ). Changed prior to commit: https://reviews.llvm.org/D54476?vs=174405&id=1747

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz added a comment. My change for lldb-server (https://reviews.llvm.org/D5) became obsolete, but two small pieces of it are required in general/here. Added them post-approval with the update above. It's the two additions to `cmake/modules/AddLLDB.cmake` and `CMakeLists.txt`. Will leav

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz updated this revision to Diff 174405. sgraenitz added a comment. Set global LLVM_CODESIGNING_IDENTITY from LLDB_CODESIGN_IDENTITY (if given). Pass through ENTITLEMENTS from add_lldb_executable to add_llvm_executable. https://reviews.llvm.org/D54476 Files: CMakeLists.txt cmake/modu

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz added a comment. Thanks. Waiting for https://reviews.llvm.org/D54443 https://reviews.llvm.org/D54476 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks for working on this, Stefan. This LGTM. https://reviews.llvm.org/D54476 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz added a comment. Last revision changed a lot, but I think support for reconfigurations is worth it. The current state would be acceptable from my side now -- if I didn't miss anything! :-) Comment at: tools/debugserver/source/CMakeLists.txt:101 +option(LLDB_NO_DEBUG

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz updated this revision to Diff 174254. sgraenitz added a comment. Improve description for options LLDB_NO_DEBUGSERVER and LLDB_USE_SYSTEM_DEBUGSERVER https://reviews.llvm.org/D54476 Files: test/CMakeLists.txt tools/debugserver/CMakeLists.txt tools/debugserver/source/CMakeLists.t

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz updated this revision to Diff 174253. sgraenitz marked an inline comment as not done. sgraenitz edited the summary of this revision. sgraenitz added a comment. Handle reconfigurations correctly; fix configuration messages; add note for generator expressions https://reviews.llvm.org/D5

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

labath added inline comments. Comment at: tools/debugserver/source/CMakeLists.txt:101 +option(LLDB_NO_DEBUGSERVER "Delete debugserver after building it, and don't try to codesign it" OFF) +option(LLDB_USE_SYSTEM_DEBUGSERVER "Neither build nor codesign debugserver. Use the syste

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz marked 2 inline comments as not done. sgraenitz added inline comments. Comment at: tools/debugserver/source/CMakeLists.txt:128-133 +# TODO: Following the old behavior, DEBUGSERVER_PATH still points to the +# original system binary, even if we copy it over. Keep

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz updated this revision to Diff 174053. sgraenitz marked 4 inline comments as done. sgraenitz added a comment. debugserver cannot be ad-hoc code signed; handle entitlements&identity also in standalone debugserver, add feasibility checks, polishing https://reviews.llvm.org/D54476 Files:

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

JDevlieghere added inline comments. Comment at: tools/debugserver/source/CMakeLists.txt:118 + OUTPUT_VARIABLE xcode_dev_dir) +string(STRIP ${xcode_dev_dir} xcode_dev_dir) + sgraenitz wrote: > JDevlieghere wrote: > > Why did you make this variable name lo

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz added inline comments. Comment at: tools/debugserver/source/CMakeLists.txt:101 +option(LLDB_NO_DEBUGSERVER "Delete debugserver after building it, and don't try to codesign it" OFF) +option(LLDB_USE_SYSTEM_DEBUGSERVER "Neither build nor codesign debugserver. Use the sy

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

xiaobai added inline comments. Comment at: tools/debugserver/source/CMakeLists.txt:128-133 +# TODO: Following the old behavior, DEBUGSERVER_PATH still points to the +# original system binary, even if we copy it over. Keep this? +set(DEBUGSERVER_PATH "${lldb_framework

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

JDevlieghere added inline comments. Comment at: tools/debugserver/source/CMakeLists.txt:101 +option(LLDB_NO_DEBUGSERVER "Delete debugserver after building it, and don't try to codesign it" OFF) +option(LLDB_USE_SYSTEM_DEBUGSERVER "Neither build nor codesign debugserver. Use the

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, beanz, vsk, JDevlieghere. Herald added a subscriber: mgorny. Use llvm_codesign to sign debugserver with entitlements. Make individual cases more explicit: - default: build debugserver and sign with entitlements - LLDB_NO_DEBUGS