I reverted it. Thanks.
From: Aleksandr Urakov
Sent: Friday, November 30, 2018 9:25 AM
To: reviews+d53759+public+b214dcdd73261...@reviews.llvm.org
Cc: Zachary Turner ; aaron.lee.smith
; Stella Stamenova ;
llvm-comm...@lists.llvm.org; pa...@labath.sk; 15dacaoy...@gmail.com;
apra...@apple.com; jd
I'm already OOO today, feel free to revert it.
Am Fr., 30. Nov. 2018, 20:15 hat Stella Stamenova via Phabricator <
revi...@reviews.llvm.org> geschrieben:
> stella.stamenova added a comment.
>
> It looks like after this change went in, the tests on Windows starting
> timing out instead of completi
stella.stamenova added a comment.
It looks like after this change went in, the tests on Windows starting timing
out instead of completing. The last run before the change took about 2 minutes
and starting with the first run with this change, they're running for 40
minutes before being killed:
A
This revision was automatically updated to reflect the committed changes.
aleksandr.urakov marked an inline comment as done.
Closed by commit rL347962: [PDB] Support PDB-backed expressions evaluation
(authored by aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed p
aleksandr.urakov marked 2 inline comments as done.
aleksandr.urakov added inline comments.
Comment at: source/Core/RichManglingContext.cpp:134-135
get(m_cxx_method_parser)->GetBasename();
+if (!m_buffer.data())
+ m_buffer = llvm::StringRef("", 0);
return;
-
aleksandr.urakov updated this revision to Diff 175634.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53759/new/
https://reviews.llvm.org/D53759
Files:
lit/SymbolFile/PDB/Inputs/ExpressionsTest.cpp
lit/SymbolFile/PDB/Inputs/ExpressionsTest0.script
lit/SymbolFile/PDB/Inputs/Expressio
labath added inline comments.
Comment at: source/Core/RichManglingContext.cpp:134-135
get(m_cxx_method_parser)->GetBasename();
+if (!m_buffer.data())
+ m_buffer = llvm::StringRef("", 0);
return;
Why is this necessary? It looks like somebody
aleksandr.urakov added a comment.
Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53759/new/
https://reviews.llvm.org/D53759
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
asmith accepted this revision.
asmith added a comment.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53759/new/
https://reviews.llvm.org/D53759
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
aleksandr.urakov added a comment.
Ping!
Can someone to have a look as well?
https://reviews.llvm.org/D53759
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aleksandr.urakov updated this revision to Diff 171489.
aleksandr.urakov marked 2 inline comments as done.
aleksandr.urakov added a comment.
Update the diff according to comments.
https://reviews.llvm.org/D53759
Files:
lit/SymbolFile/PDB/Inputs/ExpressionsTest.cpp
lit/SymbolFile/PDB/Inputs/E
aleksandr.urakov marked 2 inline comments as done.
aleksandr.urakov added inline comments.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:819
if (!section_list)
m_entry_point_address.SetOffset(offset);
else
Hui wrote:
> This still ne
stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.
A couple of comments, but looks good otherwise. I'd wait for someone else to
have a look as well.
Comment at: source/Plugins/Process/Windows/Common/Proce
Hui added inline comments.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:819
if (!section_list)
m_entry_point_address.SetOffset(offset);
else
This still needs to be the offset into the section.
Repository:
rLLDB LLDB
https://re
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, asmith, stella.stamenova.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, teemperor, JDevlieghere, aprantl.
This patch contains several small fixes, which makes it possible to evaluat
15 matches
Mail list logo
