I reverted it. Thanks. From: Aleksandr Urakov <aleksandr.ura...@jetbrains.com> Sent: Friday, November 30, 2018 9:25 AM To: reviews+d53759+public+b214dcdd73261...@reviews.llvm.org Cc: Zachary Turner <ztur...@google.com>; aaron.lee.smith <aaron.lee.sm...@gmail.com>; Stella Stamenova <sti...@microsoft.com>; llvm-comm...@lists.llvm.org; pa...@labath.sk; 15dacaoy...@gmail.com; apra...@apple.com; jdevliegh...@apple.com; teempe...@gmail.com; lldb-commits@lists.llvm.org; sani...@subpath.org; chi...@raincode.com; b.gia...@gmail.com Subject: Re: [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation
I'm already OOO today, feel free to revert it. Am Fr., 30. Nov. 2018, 20:15 hat Stella Stamenova via Phabricator <revi...@reviews.llvm.org<mailto:revi...@reviews.llvm.org>> geschrieben: stella.stamenova added a comment. It looks like after this change went in, the tests on Windows starting timing out instead of completing. The last run before the change took about 2 minutes and starting with the first run with this change, they're running for 40 minutes before being killed: After: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1774<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flab.llvm.org%3A8014%2Fbuilders%2Flldb-x64-windows-ninja%2Fbuilds%2F1774&data=02%7C01%7CSTILIS%40microsoft.com%7Ce979eb1bf9bc47eb793008d656e8d4a1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636791955351801306&sdata=w0HJyE7Tqbd84qnmwtEnPbqSMGehVN3TqdiZVnAgGig%3D&reserved=0> Before: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1773<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flab.llvm.org%3A8014%2Fbuilders%2Flldb-x64-windows-ninja%2Fbuilds%2F1773&data=02%7C01%7CSTILIS%40microsoft.com%7Ce979eb1bf9bc47eb793008d656e8d4a1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636791955351801306&sdata=T3mIA7QHgr89xwpOa8omn2SRGsVSlDPdorRbXn61Q4U%3D&reserved=0> Can you fix this today or pull the change out? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53759/new/<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD53759%2Fnew%2F&data=02%7C01%7CSTILIS%40microsoft.com%7Ce979eb1bf9bc47eb793008d656e8d4a1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636791955351811315&sdata=juwD4303lDo%2Bu%2BQQ1N5vAZ8%2FsnsmNv7bC9QnP6ukY8U%3D&reserved=0> https://reviews.llvm.org/D53759<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD53759&data=02%7C01%7CSTILIS%40microsoft.com%7Ce979eb1bf9bc47eb793008d656e8d4a1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636791955351811315&sdata=%2BLb60xqfhy8xBYqi0%2FFXMpZgtQQ7FY4h%2BQrCW3evCU4%3D&reserved=0>
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
