aleksandr.urakov added a comment.
Thank you!
https://reviews.llvm.org/D52461
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thanks for your patience. This looks good to me now.
https://reviews.llvm.org/D52461
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
aleksandr.urakov updated this revision to Diff 172102.
https://reviews.llvm.org/D52461
Files:
lit/SymbolFile/PDB/Inputs/AstRestoreTest.cpp
lit/SymbolFile/PDB/ast-restore.test
source/Plugins/Language/CPlusPlus/CMakeLists.txt
source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
source/
aleksandr.urakov updated this revision to Diff 172101.
https://reviews.llvm.org/D52461
Files:
lit/SymbolFile/PDB/Inputs/AstRestoreTest.cpp
lit/SymbolFile/PDB/ast-restore.test
source/Plugins/Language/CPlusPlus/CMakeLists.txt
source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
source/
aleksandr.urakov marked 2 inline comments as done.
aleksandr.urakov added a comment.
Thank you for comments! I've updated the patch.
https://reviews.llvm.org/D52461
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
labath added a comment.
It's not fully clear to me from the previous comments if you are proceeding
with this or not, but in case you are, I have made comments inline. I see that
you've added some lit tests, but I also think you it would be good add some
unit tests for the name parser functiona
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D52461#1281742, @zturner wrote:
> What do you think?
Yes, it's a really cool idea! When I was starting the implementation of the
parser from this patch, I thought that it would be good to have mangled names
instead - then we could
zturner added a comment.
In https://reviews.llvm.org/D52461#1280527, @aleksandr.urakov wrote:
> Update the diff according to the discussion, making it possible to parse MSVC
> demangled names by `CPlusPlusLanguage`. The old PDB plugin still uses
> `MSVCUndecoratedNameParser` directly because:
>
aleksandr.urakov updated this revision to Diff 171707.
aleksandr.urakov retitled this revision from "[PDB] Introduce `PDBNameParser`"
to "[PDB] Introduce `MSVCUndecoratedNameParser`".
aleksandr.urakov edited the summary of this revision.
aleksandr.urakov added a reviewer: shafik.
aleksandr.urakov
