xiaobai added a comment.
In https://reviews.llvm.org/D50038#1184445, @clayborg wrote:
> Might be nice to put a blurb in the build page about this in the MacOS
> section?
Yep, I think that wouldn't be a bad idea. I can handle that in a separate
commit. Might be nice for one of the buildbots to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338594: Introduce install-lldb-framework target (authored by
xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50038
Files:
lldb/trunk/C
clayborg added a comment.
Might be nice to put a blurb in the build page about this in the MacOS section?
https://reviews.llvm.org/D50038
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D50038
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lld
xiaobai updated this revision to Diff 158329.
xiaobai added a comment.
Address comments
https://reviews.llvm.org/D50038
Files:
CMakeLists.txt
cmake/modules/AddLLDB.cmake
cmake/modules/LLDBFramework.cmake
source/API/CMakeLists.txt
Index: source/API/CMakeLists.txt
===
xiaobai added a comment.
In https://reviews.llvm.org/D50038#1181817, @labath wrote:
> I am glad filing the cmake bug has paid off. :)
Same! :)
Comment at: cmake/modules/AddLLDB.cmake:81-87
+ # install-liblldb{,-stripped} is the actual target that will install the
+ # frame
labath added a comment.
I am glad filing the cmake bug has paid off. :)
I just have one small question about this patch.
Comment at: cmake/modules/AddLLDB.cmake:81-87
+ # install-liblldb{,-stripped} is the actual target that will install the
+ # framework, so it must rely on
xiaobai added a comment.
Using this patch, I was able to build the lldb framework and install it. I
configured with:
cmake .. -G Ninja -DCMAKE_BUILD_TYPE=Release -DLLDB_CODESIGN_IDENTITY=""
-DLLDB_BUILD_FRAMEWORK=1 -DLLDB_USE_SYSTEM_SIX=1 -DCMAKE_INSTALL_PREFIX=""
-DLLVM_TARGETS_TO_BUILD="X8
xiaobai created this revision.
xiaobai added reviewers: labath, sas.
Herald added a subscriber: mgorny.
Previously, I thought that install-liblldb would fail because CMake had
a bug related to installing frameworks. In actuality, I misunderstood the
semantics of `add_custom_target`: the DEPENDS op
