xiaobai added a comment.
In https://reviews.llvm.org/D50038#1181817, @labath wrote:
> I am glad filing the cmake bug has paid off. :)
Same! :)
================
Comment at: cmake/modules/AddLLDB.cmake:81-87
+ # install-liblldb{,-stripped} is the actual target that will install the
+ # framework, so it must rely on the framework being fully built first.
+ if (LLDB_BUILD_FRAMEWORK AND ${name} STREQUAL "liblldb")
+ add_dependencies(install-${name} lldb-framework)
+ add_dependencies(install-lldb-framework-stripped lldb-framework)
+ endif()
+
----------------
labath wrote:
> Shouldn't this be also guarded under the `NOT LLVM_INSTALL_TOOLCHAIN_ONLY`,
> like the code above? If someone sets `LLVM_INSTALL_TOOLCHAIN_ONLY=True`, then
> the install-liblldb target will not even be generated and these lines will
> fail (or just do something weird).
Ahh, yeah I think you're right. I think it should actually be a level deeper in
`if (NOT CMAKE_CONFIGURATION_TYPES)`. I'll amend this.
https://reviews.llvm.org/D50038
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
