nealsid added a comment.
In https://reviews.llvm.org/D49963#1183036, @clayborg wrote:
> This will be very cool. Biggest issues to watch out for is to make sure it
> doesn't return incorrect values when running for things like the thread
> count. If you switch to use the
> "m_debugger.GetComman
nealsid accepted this revision.
nealsid added inline comments.
This revision is now accepted and ready to land.
Comment at: include/lldb/Host/Editline.h:187
+ /// Register a callback to retrieve the prompt.
+ void SetPromptCallback(PromptCallbackType callback, void *baton);
+
labath added a comment.
Sounds like a nice feature to have. In addition to the other feedback you've
received, I'd suggest splitting out the addition of new format entities (frame
count and friends) and the core interpolation feature into separate patches.
Repository:
rL LLVM
https://review
clayborg added a comment.
This will be very cool. Biggest issues to watch out for is to make sure it
doesn't return incorrect values when running for things like the thread count.
If you switch to use the
"m_debugger.GetCommandInterpreter().GetExecutionContext()" it should solve this
by making
zturner added reviewers: labath, jasonmolenda.
zturner added inline comments.
Comment at: include/lldb/Host/Editline.h:187
+ /// Register a callback to retrieve the prompt.
+ void SetPromptCallback(PromptCallbackType callback, void *baton);
+
I'd love to stop
