nealsid added a comment.

In https://reviews.llvm.org/D49963#1183036, @clayborg wrote:

> This will be very cool. Biggest issues to watch out for is to make sure it 
> doesn't return incorrect values when running for things like the thread 
> count. If you switch to use the 
> "m_debugger.GetCommandInterpreter().GetExecutionContext()" it should solve 
> this by making sure the frame and thread are not filled in when the process 
> is running.  It might also be racy. For example if you say "continue", 
> hopefully the process will be resumed by the time the prompt is asked to 
> refresh itself. Since we get events asynchronously this might be a problem.


Nice - TBH, I haven't used LLDB in awhile so having the prompt displayed while 
the target is running wasn't on my list of test cases, but I'll definitely add 
it.  
Perhaps there could also be an indicator like '*' in the prompt when the 
process is currently running so the user will know it's potentially out of date.


Repository:
  rL LLVM

https://reviews.llvm.org/D49963



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to