clayborg added inline comments.
Comment at:
lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:860
PyRefType::Owned,
-Py_BuildValue("(Os)", session_dict.get(), command));
+Py_BuildValue("(Os)", session_
dblaikie added subscribers: teemperor, dblaikie.
dblaikie added a comment.
If the implementation of a function requires a string - it should probably
accept string (not a StringRef) as a parameter - to avoid back-and-forth
conversions in cases where the caller already has a string to use.
Repos
If the implementation of a function requires a string - it should probably
accept string (not a StringRef) as a parameter - to avoid back-and-forth
conversions in cases where the caller already has a string to use.
On Fri, Jul 13, 2018 at 12:43 PM Stella Stamenova via Phabricator via
llvm-commits
stella.stamenova added a comment.
All better now! Tests are passing.
Repository:
rL LLVM
https://reviews.llvm.org/D49309
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337030: No longer pass a StringRef to the Python API
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49309?vs=155434&i
teemperor added a comment.
@stella.stamenova I believe this fixes the issue. Thanks for finding this!
https://reviews.llvm.org/D49309
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
teemperor created this revision.
teemperor added a reviewer: stella.stamenova.
The refactoring patch for DoExecute missed this case of a variadic function
that just silently
accepts a StringRef which it then tries to reinterpret as a C-string.
This should fix the Windows builds.
https://review
