If the implementation of a function requires a string - it should probably accept string (not a StringRef) as a parameter - to avoid back-and-forth conversions in cases where the caller already has a string to use.
On Fri, Jul 13, 2018 at 12:43 PM Stella Stamenova via Phabricator via llvm-commits <llvm-comm...@lists.llvm.org> wrote: > stella.stamenova added a comment. > > All better now! Tests are passing. > > > Repository: > rL LLVM > > https://reviews.llvm.org/D49309 > > > > _______________________________________________ > llvm-commits mailing list > llvm-comm...@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
