This revision was automatically updated to reflect the committed changes.
Closed by commit rL335963: UUID: Add support for arbitrary-sized module IDs
(authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48633
Files:
lldb
labath updated this revision to Diff 153321.
labath added a comment.
Add a check to the tab-completion function.
https://reviews.llvm.org/D48633
Files:
include/lldb/Utility/UUID.h
source/Interpreter/OptionValueUUID.cpp
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Utility/UUID.
labath added inline comments.
Comment at: source/Interpreter/OptionValueUUID.cpp:82
+ llvm::SmallVector uuid_bytes;
+ UUID::DecodeUUIDBytesFromString(s, uuid_bytes);
for (size_t i = 0; i < num_modules; ++i) {
clayborg wrote:
> Probably should hav
clayborg added inline comments.
Comment at: source/Interpreter/OptionValueUUID.cpp:82
+ llvm::SmallVector uuid_bytes;
+ UUID::DecodeUUIDBytesFromString(s, uuid_bytes);
for (size_t i = 0; i < num_modules; ++i) {
Probably should have a return value
labath created this revision.
labath added reviewers: clayborg, lemo, sas, davide.
Herald added subscribers: arichardson, emaste.
Herald added a reviewer: espindola.
The data structure is optimized for the case where the UUID size is <=
20 bytes (standard length emitted by the GNU linkers), but la
