[Lldb-commits] [PATCH] D47992: [lldb-mi] Clean up and update a few MI commands.

This revision was automatically updated to reflect the committed changes. Closed by commit rL336009: [lldb-mi] Clean up and update a few MI commands. (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D47992?vs=1526

[Lldb-commits] [PATCH] D47992: [lldb-mi] Clean up and update a few MI commands.

apolyakov updated this revision to Diff 152694. apolyakov added a comment. Removed unnecessary `this->`. https://reviews.llvm.org/D47992 Files: tools/lldb-mi/MICmdCmdExec.cpp tools/lldb-mi/MICmdCmdExec.h Index: tools/lldb-mi/MICmdCmdExec.h ==

[Lldb-commits] [PATCH] D47992: [lldb-mi] Clean up and update a few MI commands.

clayborg added inline comments. Comment at: tools/lldb-mi/MICmdCmdExec.cpp:139 + const CMIUtilString &rErrMsg(CMIDriver::Instance().GetErrorDescription()); + this->SetError(CMIUtilString::Format( + MIRSRC(IDS_CMD_ERR_SET_NEW_DRIVER_STATE), any

[Lldb-commits] [PATCH] D47992: [lldb-mi] Clean up and update a few MI commands.

apolyakov updated this revision to Diff 152589. apolyakov added a comment. Removed accidentally added comment, added `const` qualifier to lambdas. https://reviews.llvm.org/D47992 Files: tools/lldb-mi/MICmdCmdExec.cpp tools/lldb-mi/MICmdCmdExec.h Index: tools/lldb-mi/MICmdCmdExec.h

[Lldb-commits] [PATCH] D47992: [lldb-mi] Clean up and update a few MI commands.

apolyakov added inline comments. Comment at: tools/lldb-mi/MICmdCmdExec.cpp:137 + auto successHandler = [this] { +// CODETAG_DEBUG_SESSION_RUNNING_PROG_RECEIVED_SIGINT_PAUSE_PROGRAM +if (!CMIDriver::Instance().SetDriverStateRunningDebugging()) { aprantl

[Lldb-commits] [PATCH] D47992: [lldb-mi] Clean up and update a few MI commands.

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: tools/lldb-mi/MICmdCmdExec.cpp:137 + auto successHandler = [this] { +// CODETAG_DEBUG_SESSION_RUNNING_PROG_RECEIVED_SIGINT_PAUSE_PROGRAM +if (!CMID

[Lldb-commits] [PATCH] D47992: [lldb-mi] Clean up and update a few MI commands.

apolyakov added a comment. Would be really nice to get review of this patch before this weekend. Thanks for your time, folks. https://reviews.llvm.org/D47992 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D47992: [lldb-mi] Clean up and update a few MI commands.

clayborg added a comment. fine with leaving it as is if needed as well https://reviews.llvm.org/D47992 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47992: [lldb-mi] Clean up and update a few MI commands.

apolyakov added a comment. I don't like creating a new class just for one feature. It looks like only 3 commands use that code, so maybe we should let it be at it is? https://reviews.llvm.org/D47992 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D47992: [lldb-mi] Clean up and update a few MI commands.

clayborg added a comment. In https://reviews.llvm.org/D47992#1139691, @apolyakov wrote: > I didn't committed patch https://reviews.llvm.org/D48295 yet, so I think if > we change `HandleSBError` handlers from > `std::function` to `std::function` > we'll be able to create anonymous namespace and

[Lldb-commits] [PATCH] D47992: [lldb-mi] Clean up and update a few MI commands.

apolyakov updated this revision to Diff 152351. apolyakov retitled this revision from "[lldb-mi] Correct error processing in exec-next command." to "[lldb-mi] Clean up and update a few MI commands.". apolyakov edited the summary of this revision. apolyakov added a comment. I didn't committed patc