[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

2018-06-03 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd added inline comments. Comment at: scripts/Python/modules/readline/CMakeLists.txt:11 + PRIVATE + ${libedit_INCLUDE_DIRS}) if (NOT LLDB_DISABLE_LIBEDIT) lonico77 wrote: > Should this be under if (NOT

[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

2018-06-03 Thread Laurent Nicolas via Phabricator via lldb-commits
lonico77 added inline comments. Comment at: scripts/Python/modules/readline/CMakeLists.txt:11 + PRIVATE + ${libedit_INCLUDE_DIRS}) if (NOT LLDB_DISABLE_LIBEDIT) Should this be under if (NOT LLDB_DISABLE_LIBE

[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

2018-05-22 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd closed this revision. compnerd added a comment. SVN r333041 https://reviews.llvm.org/D46726 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

2018-05-22 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Ok, let's give this a try. https://reviews.llvm.org/D46726 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

2018-05-21 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd updated this revision to Diff 147874. compnerd added a comment. fix regex https://reviews.llvm.org/D46726 Files: CMakeLists.txt cmake/modules/FindLibEdit.cmake scripts/Python/modules/readline/CMakeLists.txt Index: scripts/Python/modules/readline/CMakeLists.txt =

[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

2018-05-21 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd added inline comments. Comment at: cmake/modules/FindLibEdit.cmake:53-54 +set(libedit_VERSION_STRING "${libedit_major_version}.${libedit_minor_version}") +unset(libedit_major_version) +unset(libedit_minor_version) + endif() labath wrote: >

[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

2018-05-14 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: cmake/modules/FindLibEdit.cmake:11-14 +# libedit_FOUND - true if libedit was found +# libedit_INCLUDE_DIRS - include search path +# libedit_LIBRARIES - libraries to link +# libedit_VERSION - version number -

[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

2018-05-11 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd added inline comments. Comment at: cmake/modules/FindLibEdit.cmake:11-14 +# libedit_FOUND - true if libedit was found +# libedit_INCLUDE_DIRS - include search path +# libedit_LIBRARIES - libraries to link +# libedit_VERSION - version number ---

[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

2018-05-11 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. The patch looks quite nice, though I can't say I know much about how find_package modules are supposed to be written. I won't click accept yet to see if anyone with more cmake knowledge steps in to review. In the mean time, I have two nitty comments.

[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

2018-05-10 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd created this revision. compnerd added reviewers: davide, labath, vsk, zturner. Herald added a subscriber: mgorny. Use proper cmake techniques to detect where the libedit package resides. This allows for the use of libedit from an alternative location which is needed for supporting cross-c