[Lldb-commits] [PATCH] D44139: Update selected thread after loading mach core

This revision was automatically updated to reflect the committed changes. Closed by commit rL327501: Update selected thread after loading mach core (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D44139?vs=137993&id=138331#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D44139: Update selected thread after loading mach core

JDevlieghere added a comment. In https://reviews.llvm.org/D44139#1036521, @jasonmolenda wrote: > (or rather, not "conflict with the OperatingSystemPlugIn stop reason" -- but > would make it confusing to users. I think it might be best to remove > ThreadMachCore::CalculateStopInfo.) Sounds re

[Lldb-commits] [PATCH] D44139: Update selected thread after loading mach core

jasonmolenda added a comment. (or rather, not "conflict with the OperatingSystemPlugIn stop reason" -- but would make it confusing to users. I think it might be best to remove ThreadMachCore::CalculateStopInfo.) https://reviews.llvm.org/D44139 __

[Lldb-commits] [PATCH] D44139: Update selected thread after loading mach core

jasonmolenda accepted this revision. jasonmolenda added a comment. Looks good, thanks for doing this Jonas. I thought there would be a problem with ThreadMachCore::CalculateStopInfo() in source/Plugins/Process/mach-core/ThreadMachCore.cpp which will mark every thread that comes from the actual

[Lldb-commits] [PATCH] D44139: Update selected thread after loading mach core

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Looks great! Thanks for working through this. https://reviews.llvm.org/D44139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:/

[Lldb-commits] [PATCH] D44139: Update selected thread after loading mach core

JDevlieghere updated this revision to Diff 137993. JDevlieghere added a comment. Thanks for the review @labath! https://reviews.llvm.org/D44139 Files: packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py packages/Python/lldbsuite/test/functionalities/postmor

[Lldb-commits] [PATCH] D44139: Update selected thread after loading mach core

labath added a comment. I'll leave the cpp change for others to approve (though it certainly looks simpler than the previous one). I just have a couple of drive-by comments on the test. Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachC

[Lldb-commits] [PATCH] D44139: Update selected thread after loading mach core

JDevlieghere updated this revision to Diff 137762. JDevlieghere retitled this revision from "WIP: Update selected thread after loading mach core" to "Update selected thread after loading mach core". JDevlieghere edited the summary of this revision. JDevlieghere added a comment. - Added testcase.