labath added a comment.
I'll leave the cpp change for others to approve (though it certainly looks
simpler than the previous one). I just have a couple of drive-by comments on
the test.
================
Comment at:
packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py:32
+ # Create core form YAML.
+ self.yaml2obj("test.core.yaml", "test.core")
+
----------------
this should be `getBuildArtifact("test.core") `, so it does not end up in the
test tree (we may also consider changing the interface of this function to make
it harder to get wrong).
================
Comment at:
packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/operating_system.py:1-2
+#!/usr/bin/python
+
+import lldb
----------------
It doesn't look like this is actually executable.
Repository:
rL LLVM
https://reviews.llvm.org/D44139
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
