[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

2018-01-31 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. Thanks a lot for your help, Pavel! We also discovered the most amazing test failure on the green dragon bots yesterday (fix still underway) that was made much worse by my patch. On Darwin LLDB automatically tries to find a .dSYM bundle for an executable by querying the

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

2018-01-31 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D42281#992359, @aprantl wrote: > In https://reviews.llvm.org/D42281#992295, @aprantl wrote: > > > There are a few test failures, but they look manageable. I will need help > > resolving them though: > > > Updated list: > > http://lab.llvm.org:8

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

2018-01-30 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. In https://reviews.llvm.org/D42281#992295, @aprantl wrote: > There are a few test failures, but they look manageable. I will need help > resolving them though: Updated list: http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/7843 FAIL: TestLoadUnload.Load

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

2018-01-30 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. There are a few test failures, but they look manageable. I will need help resolving them though: http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/7843 FAIL: TestLoadUnload.LoadUnloadTestCase.test_lldb_process_load_and_unload_commands_dwarf http://lab.llvm

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

2018-01-30 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. Let's see how this fares on the bots. As I mentioned in the commit message, please don't hesitate to revert this patch. I'm watching all bots connected to lab.llvm.org, and green.lab.llvm.org but please let me know if I'm missing something. Repository: rL LLVM http

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

2018-01-30 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. Right, so I tried this out on windows today (targetting android, because I know the state of that target, but I think this should catch problems with windows host builds as well). The main problem i ran into is that `$(realpath)` is just br

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

2018-01-29 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. In https://reviews.llvm.org/D42281#990296, @labath wrote: > In https://reviews.llvm.org/D42281#989793, @aprantl wrote: > > > I am now working on building each test variant (dwarf,dwo,dsym,...) in its > > own build directory so they can run in parallel and we can get rid

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

2018-01-29 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I haven't gotten around to trying this out on windows yet, but I have tried running the tests remotely. I've updated https://reviews.llvm.org/D42572 with the two fixes necessary to make the remote tests pass (for android). https://reviews.llvm.org/D42281

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

2018-01-29 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D42281#989793, @aprantl wrote: > I am now working on building each test variant (dwarf,dwo,dsym,...) in its > own build directory so they can run in parallel and we can get rid of the > lockfile. Are you planning to merge that into this patc

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

2018-01-27 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. I found the mechanism I was looking for. Generic testcases set `NO_DEBUG_INFO_TESTCASE = True` https://reviews.llvm.org/D42281 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

2018-01-26 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. I am now working on building each test variant (dwarf,dwo,dsym,...) in its own build directory so they can run in parallel and we can get rid of the lockfile. While doing this I discovered that certain tests (e.g., TestPublicAPIHeaders.py, the MI tests) are invoking bui

[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

2018-01-26 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/api/check_public_api_headers/TestPublicAPIHeaders.py:46 self.line_to_break = line_number( -self.source, '// Set breakpoint here.') +self.getBuildArtifact(self.source), '//