clayborg added a comment.
Looks good.
Repository:
rL LLVM
https://reviews.llvm.org/D41533
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322209: Advanced guessing of rendezvous breakpoint (authored
by eugene, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D41533?vs=129216&id=129
ted added a comment.
Thanks for adding me, Pavel.
Hexagon running Linux uses this plugin. These changes lgtm.
Standalone Hexagon uses its own dyld plugin; I need to look at it and see if I
want to pull any of these ideas into it.
https://reviews.llvm.org/D41533
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
looks good, thanks.
https://reviews.llvm.org/D41533
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
eugene updated this revision to Diff 129216.
eugene marked an inline comment as done.
eugene added a comment.
Addressing code review comments. Switching from manual symbol resolution to
the appropriate overload of CreateBreakpoint.
https://reviews.llvm.org/D41533
Files:
packages/Python/ll
eugene marked 5 inline comments as done.
eugene added inline comments.
Comment at:
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:365-368
+static const char *DebugStateCandidates[] = {
+"_dl_debug_state", "rtld_db_dlactivity", "__dl_rtld_db_dlacti
clayborg added a comment.
Looks fine. Set the breakpoint using the list of names and delete the
breakpoint if you get no locations and this will be good to go.
Comment at:
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:365-368
+static const char *Debug
labath added subscribers: emaste, krytarowski, ted.
labath added a comment.
I'm adding some people with non-linux non-x86/arm targets who use this plugin
for more visibility. I have a couple of small comments, but in general, I am
happy with this.
Comment at:
packages/Python
eugene updated this revision to Diff 129002.
eugene edited the summary of this revision.
eugene added a reviewer: tberghammer.
eugene added a project: LLDB.
eugene added a subscriber: lldb-commits.
eugene added a comment.
Fix tests.
https://reviews.llvm.org/D41533
Files:
packages/Python/lldb
