Re: [Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

2017-12-04 Thread Pavel Labath via lldb-commits
On 1 December 2017 at 19:42, Jim Ingham wrote: > This certainly should be cleared up and centralized. I'm not quite as sure > it should be in Platform however. For instance, macOS has the DebugSymbols > framework that allows users to specify a local lookup tool to find symbol > files given a

Re: [Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

2017-12-01 Thread Jim Ingham via lldb-commits
This certainly should be cleared up and centralized. I'm not quite as sure it should be in Platform however. For instance, macOS has the DebugSymbols framework that allows users to specify a local lookup tool to find symbol files given a UUID. That runs only on MacOS and requires MacOS specif

Re: [Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

2017-12-01 Thread Jan Kratochvil via lldb-commits
On Fri, 01 Dec 2017 13:02:42 +0100, Pavel Labath wrote: > > I expect because LLDB does not have any Linux DWARF index support, it has > > only some Apple OSX index support. GDB's `.debug_index` is not usable for > > LLDB as it does not contain DIE offsets. I would like to implement DWARF-5 > > `.de

Re: [Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

2017-12-01 Thread Pavel Labath via lldb-commits
On 30 November 2017 at 20:17, Jan Kratochvil via Phabricator wrote: > jankratochvil added a comment. > > In https://reviews.llvm.org/D40475#940462, @labath wrote: > >> It looks like it could be a fun project to reimplement `dwz` on top of llvm >> dwarf library, but I understand that would be a co

Re: [Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

2017-12-01 Thread Pavel Labath via lldb-commits
On 30 November 2017 at 19:10, Zachary Turner via Phabricator wrote: > zturner added a comment. > > In https://reviews.llvm.org/D40475#935615, @labath wrote: > >> The thing to be aware of with this testing strategy is that you will >> probably be the only person who will be able to run these tests

Re: [Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

2017-12-01 Thread Pavel Labath via lldb-commits
On 30 November 2017 at 19:08, Jim Ingham wrote: > We had a similar problem with the tests on macOS. lldb has a facility that > will do automatic lookup of UUID -> dSYM (macOS's separate debug info format) > and if you are internal to Apple this will find all the system library debug > info. T

[Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

2017-11-30 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. In https://reviews.llvm.org/D40475#940462, @labath wrote: > It looks like it could be a fun project to reimplement `dwz` on top of llvm > dwarf library, but I understand that would be a considerable detour for you. I think it would be best to drop DWZ, IIRC its g

[Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

2017-11-30 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. In https://reviews.llvm.org/D40475#935615, @labath wrote: > The thing to be aware of with this testing strategy is that you will probably > be the only person who will be able to run these tests and verify dwz > functionality. If you don't setup a buildbot testing this

Re: [Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

2017-11-30 Thread Jim Ingham via lldb-commits
We had a similar problem with the tests on macOS. lldb has a facility that will do automatic lookup of UUID -> dSYM (macOS's separate debug info format) and if you are internal to Apple this will find all the system library debug info. That will cause a handful of tests to fail, mostly because

[Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

2017-11-30 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. @jankratochvil I run Fedora for now on my desktop, but I don't have time and resources to devote to a buildbot. IMHO, having a fedora bot would be a great thing for two reasons: 1. I found out Fedora exposes bugs that ubuntu doesn't (e.g. in symbol resolution, due to sli

[Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

2017-11-30 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D40475#940226, @jankratochvil wrote: > > you will probably be the only person who will be able to run these tests > > and verify dwz functionality. > > OK; really nobody runs RHEL/CentOS/Fedora? :-) There aren't that many lldb developers... I

[Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

2017-11-30 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. > you will probably be the only person who will be able to run these tests and > verify dwz functionality. OK; really nobody runs RHEL/CentOS/Fedora? :-) > If you don't setup a buildbot testing OK, I will try that. I was even running a test bot for GDB. > These

[Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

2017-11-27 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. The thing to be aware of with this testing strategy is that you will probably be the only person who will be able to run these tests and verify dwz functionality. If you don't setup a buildbot testing this then other developers will never even know if they have broken an

[Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

2017-11-26 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil created this revision. Herald added subscribers: eraman, aprantl. Many ERRORs are correct because for many *_dwz testcases DWZ cannot be applied. Otherwise their tests would be duplicating their *_dwarf counterparts. Using for regression comparison of *_dwz against *_dwarf: rm -